QtMir

Code review comment for lp://staging/~nick-dedekind/qtmir/multiwindow.textures

  1. multiwindow.textures
  2. Merge into trunk
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> > > The cyclic dependency between MirSurfaceItem and its
> > > SurfaceItemTextureProvider looks unnecessary. Can't the former can update
> > the
> > > latter upon QQuickItem::smoothChanged()?
> > >
> > > That might even lead to more correct code as it will update
> > > SurfaceItemTextureProvider's filtering in more situations than the current
> > > implementation.
> >
> > Where is there a cyclic dependency?
>
> Item has TextureProvider and TextureProvider has Item.

Removed. Added TextureProvider::setSmooth

Reply

« Back to merge proposal