Code review comment for lp://staging/~nick-dedekind/qtmir/multiwindow.textures

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> The cyclic dependency between MirSurfaceItem and its
> SurfaceItemTextureProvider looks unnecessary. Can't the former can update the
> latter upon QQuickItem::smoothChanged()?
>
> That might even lead to more correct code as it will update
> SurfaceItemTextureProvider's filtering in more situations than the current
> implementation.

Where is there a cyclic dependency? The items texture is dependant on the items smooth property.

« Back to merge proposal