Code review comment for lp://staging/~neric27/midori/mz-sync
Revision history for this message
| Eric Le Lay (neric27) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
> I noticed one tiny obvious bug: base32_size calls ceil() on an integer
> argument after doing an integer division. You're better off adding four and
> then dividing by five, all in integer math.
Yes, you're right!
With len=1 it was producing 0...
Luckily it was only called with 20.
I'll fix my code as you suggest.
Thank you very much!!