Code review comment for lp://staging/~neric27/midori/mz-sync

Revision history for this message
gue5t gue5t (gue5t) wrote :

This is pretty impressive, and I'm glad you've paid attention to memory management concerns. :)

I noticed one tiny obvious bug: base32_size calls ceil() on an integer argument after doing an integer division. You're better off adding four and then dividing by five, all in integer math.

« Back to merge proposal