Code review comment for lp://staging/~nataliabidart/magicicada-server/no-u1-devtools

Revision history for this message
Facundo Batista (facundo) wrote :

+1

Couldn't really tested, have a broken env.

I got complains about magicicada/settings/testing.py, though; like "F405 os may be undefined, or defined from star imports: magicicada.settings"; maybe we could avoid that "import *"

Anyway, if you're sure that logs are being produced ok in test and normal server mode, go ahead :)

review: Approve

« Back to merge proposal