Merge ~nacc/git-ubuntu:lp1734905-script-fixes into git-ubuntu:master

Proposed by Nish Aravamudan
Status: Superseded
Proposed branch: ~nacc/git-ubuntu:lp1734905-script-fixes
Merge into: git-ubuntu:master
Prerequisite: ~nacc/git-ubuntu:lp1734905-script-cleanups
Diff against target: 1189 lines (+719/-300)
8 files modified
bin/import-source-packages.py (+17/-22)
bin/source-package-walker.py (+20/-83)
bin/update-repository-alias.py (+1/-2)
dev/null (+0/-192)
gitubuntu/scriptutils.py (+496/-0)
gitubuntu/scriptutils_test.py (+155/-0)
snap/snapcraft.yaml (+23/-0)
tox.ini (+7/-1)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Needs Fixing
Robie Basak Needs Fixing
Review via email: mp+336878@code.staging.launchpad.net

This proposal supersedes a proposal from 2018-01-26.

This proposal has been superseded by a proposal from 2018-02-02.

Description of the change

Total WIP, but suitable for discussion tomorrow.

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:00b556d29d30bcc9bfa6f13f8fae5f18490e04c4
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/273/
Executed test runs:
    SUCCESS: Checkout
    FAILED: Style Check

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/273/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Robie Basak (racb) wrote :

We've agreed to use pytest for test parameterisation.

review: Needs Fixing
Revision history for this message
Nish Aravamudan (nacc) wrote :

Have not updated to pytest yet, but this now pulls the scripts into the snap and then runs the tests on them in the snap as part of the self-test.

I'll break this out to multiple MPs tomorrow.

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:a0294be00c14df6d912db95e95972518d1f6da53
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/277/
Executed test runs:
    SUCCESS: Checkout
    FAILED: Style Check

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/277/rebuild

review: Needs Fixing (continuous-integration)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches