Code review comment for lp://staging/~mzanetti/ubuntu-clock-app/detect-qtmm-version

Revision history for this message
Michael Zanetti (mzanetti) wrote :

fixed the inline comment.

For me, the volume controls during preview were working fine. Probably the issue was because before it was using the "alert" role, which seems to be wrong in any case.

As written in the description, I'm not really sure if we should merge this branch, or instead just go with the much simpler https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179

The outcome is pretty much the same with the current audio system.

« Back to merge proposal