Code review comment for lp://staging/~mwhudson/ubuntu/xenial/juju/use-dh-golang-proper

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

> Thanks Michael!
>
> Some specific questions as inline comments, but the big thing to answer is do
> we want a juju-specific answer here or something generic that this distro can
> use for other go projects?
>
> The current script is more terrifying than I imagined when we talked about the
> solution,

:-)

> but does seem to cover the edge cases well enough to be nearly
> reusable elsewhere. I think we could simplify it a fair by using
> dependencies.tsv from the github.com/juju/juju tree if we decide this is going
> to remain a juju-only packaging solution.

Oh man, I forgot about that. That makes things so much easier that I've replaced that perl script with a simple Python script instead. (I can always get the perl out of branch history if I want it again).

My new Python has the issue that having extra packages installed might affect the build, but that's not new.

> I think deb822 in python-debian does the dependency parsing bits we'd need,
> but I can live with perl.
>
> Anyway, I'm down with trying this approach for juju out in yakkety, but think
> we need to point in out and ask for feedback from a wider audience of people
> who may care about how we do golang packaging.

I'll ask in Debian what they think about the general problem (although they'll probably just say "don't bundle dependencies"...)

« Back to merge proposal