Code review comment for lp://staging/~mwhudson/livecd-rootfs/live-server-gzip-initramfs

Revision history for this message
Steve Langasek (vorlon) wrote :

On Wed, Mar 14, 2018 at 02:50:23AM -0000, Michael Hudson-Doyle wrote:
> > Yes, except that you also need to fix up the other image flavor cases to set
> > lzma where it's currently set.

> Currently not set, I assume you mean?

Yes, precisely :)

> The case statement I am editing in the current MP has 22 cases, only 2 (or
> 3 in my MP) set INITRAMFS_COMPRESSION today. It's obviously not _hard_ to
> add INITRAMFS_COMPRESSION=lzma to the other 19 but is that what you want?
> I can do it if so...

I think it's probably appropriate to add this as a separate case statement
to avoid *quite* so much code duplication; but yes, we should explicitly
call out the products individually where we want to use lzma.

« Back to merge proposal