Code review comment for lp://staging/~mvo/software-properties/use-apt-auth

Note that the pre-build hook fails when trying to build a source package with this branch. I suspect the test mocks need to be fixed for the new implementation.

Testing ./test_lp.py /home/barry/projects/ubuntu/softprop/build-area/software-properties-0.92.14/tests with python 2
EEEError getting key from keyserver: Only long keyids (v4, 160bit) are supported
...
======================================================================
ERROR: test_add_ppa_signing_key_multiple_fingerprints (__main__.AddPPASigningKeyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1224, in patched
    return func(*args, **keywargs)
  File "./test_lp.py", line 76, in test_add_ppa_signing_key_multiple_fingerprints
    with patch.object(self.t, "_get_fingerprints") as mock:
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1275, in __enter__
    original, local = self.get_original()
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1263, in get_original
    "%s does not have the attribute %r" % (target, name)
AttributeError: <AddPPASigningKeyThread(Thread-1, initial)> does not have the attribute '_get_fingerprints'

======================================================================
ERROR: test_add_ppa_signing_key_ok (__main__.AddPPASigningKeyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1224, in patched
    return func(*args, **keywargs)
  File "./test_lp.py", line 89, in test_add_ppa_signing_key_ok
    with patch.object(self.t, "_get_fingerprints") as mock:
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1275, in __enter__
    original, local = self.get_original()
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1263, in get_original
    "%s does not have the attribute %r" % (target, name)
AttributeError: <AddPPASigningKeyThread(Thread-2, initial)> does not have the attribute '_get_fingerprints'

======================================================================
ERROR: test_add_ppa_signing_key_wrong_fingerprint (__main__.AddPPASigningKeyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1224, in patched
    return func(*args, **keywargs)
  File "./test_lp.py", line 65, in test_add_ppa_signing_key_wrong_fingerprint
    with patch.object(self.t, "_get_fingerprints") as mock:
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1275, in __enter__
    original, local = self.get_original()
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1263, in get_original
    "%s does not have the attribute %r" % (target, name)
AttributeError: <AddPPASigningKeyThread(Thread-3, initial)> does not have the attribute '_get_fingerprints'

----------------------------------------------------------------------
Ran 6 tests in 1.322s

FAILED (errors=3)
make: *** [check] Error 1
bzr: ERROR: The "pre-build" hook failed.