Code review comment for lp://staging/~mvo/software-center/webapps-activation

Revision history for this message
dobey (dobey) wrote :

134 + def activate_unity_webapp_for_domain(self, domain):
135 + try:
136 + from gi.repository import UnityWebapps
137 + except ImportError:
138 + LOG.warn("failed to import UnityWebapps GIR")
139 + LOG.debug("activating webapp for domain '%s'", domain)
140 + UnityWebapps.permissions_allow_domain(domain)

The last two lines in this function need to be inside an else: I think. Otherwise an exception will be raised when permissions_allow_domain() is called, if the import failed, since you're not returning in the except handler. I guess this wasn't caught in your tests, as you're mocking that function.

+ # instal backend

Typo.

review: Needs Fixing

« Back to merge proposal