Code review comment for lp://staging/~mvo/software-center/hopefully-fix-lp1008229
Revision history for this message
| Michael Vogt (mvo) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
On Wed, Jul 11, 2012 at 01:19:19AM -0000, Gary Lasker wrote:
> Review: Approve
>
> Yep, looking at the code it seems that this would only happen on an error opening the deb file, so this fix should take care of it. I wonder why so many people are hitting this though. Anyway, defining the variable early seems the right thing to do. Thanks mvo!
I just noticed that this got merged in trunk into the debian/changelog
for the already released 5.3.4 version changelog entry. As this
version is already released a new changelog entry for 5.3.5 needs to
get started in this case. Usually the best way to tell is if the
header contains UNRELEASED or not (or using rmadison software-center
to check, but that is usually not needed). I fixed this in trunk now.
Cheers,
Michael