On Thu, Aug 09, 2012 at 02:18:17AM -0000, Gary Lasker wrote: > I merged with one tiny change that was needed to fix an exception when starting USC fresh after clearing out the files from ~/.config/software-center: > > === modified file 'softwarecenter/config.py' > --- softwarecenter/config.py 2012-08-07 12:52:25 +0000 > +++ softwarecenter/config.py 2012-08-09 02:13:48 +0000 > @@ -84,7 +84,7 @@ > > def _generic_getbool(self, option, section="general", default=False): > if not self.has_option(section, option): > - self.set(section, option, default) > + self.set(section, option, str(default)) > return self.getboolean(section, option) > > def _generic_setbool(self, option, value, section="general"):
Thanks for the review and a nice catch on this one. I added a branch that adds a testcase for this to ensure we do not regress on it (lp:~mvo/software-center/improve-test-for-config)
Cheers, Michael
« Back to merge proposal
On Thu, Aug 09, 2012 at 02:18:17AM -0000, Gary Lasker wrote: software- center: /config. py' config. py 2012-08-07 12:52:25 +0000 config. py 2012-08-09 02:13:48 +0000 getbool( self, option, section="general", default=False): option( section, option): (section, option) setbool( self, option, value, section="general"):
> I merged with one tiny change that was needed to fix an exception when starting USC fresh after clearing out the files from ~/.config/
>
> === modified file 'softwarecenter
> --- softwarecenter/
> +++ softwarecenter/
> @@ -84,7 +84,7 @@
>
> def _generic_
> if not self.has_
> - self.set(section, option, default)
> + self.set(section, option, str(default))
> return self.getboolean
>
> def _generic_
Thanks for the review and a nice catch on this one. I added a branch
that adds a testcase for this to ensure we do not regress on it
(lp:~mvo/software-center/improve-test-for-config)
Cheers,
Michael