The approach is fine. The problem is you pulled out the distinction in the case between get_icon() and get_attention_icon(). So the attention icon won't work. But I think the test is a good idea.
« Back to merge proposal
The approach is fine. The problem is you pulled out the distinction in the case between get_icon() and get_attention_ icon(). So the attention icon won't work. But I think the test is a good idea.