pkgme

Merge lp://staging/~mterry/pkgme/autoconf-helpers into lp://staging/pkgme

  1. autoconf-helpers
  2. Merge into trunk
Proposed by Michael Terry
Status: Merged
Merged at revision: 50
Proposed branch: lp://staging/~mterry/pkgme/autoconf-helpers
Merge into: lp://staging/pkgme
Diff against target: 418 lines (+214/-85)
11 files modified
pkgme/backend.py (+4/-1)
pkgme/backends/vala/homepage (+2/-31)
pkgme/backends/vala/package_name (+2/-43)
pkgme/backends/vala/want (+5/-8)
pkgme/helpers/pkgme_autoconf_config (+31/-0)
pkgme/helpers/pkgme_autoconf_description (+29/-0)
pkgme/helpers/pkgme_autoconf_homepage (+23/-0)
pkgme/helpers/pkgme_autoconf_initfield (+39/-0)
pkgme/helpers/pkgme_autoconf_maintainer (+29/-0)
pkgme/helpers/pkgme_autoconf_package_name (+42/-0)
pkgme/project_info.py (+8/-2)
To merge this branch: bzr merge lp://staging/~mterry/pkgme/autoconf-helpers
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+49697@code.staging.launchpad.net

Description of the change

We've talked about allowing a series of helper functions or programs for dealing with autotools projects (and maybe similar helper utilities for other build systems too).

I've taken the liberty of refactoring the vala backend autoconf code into several autoconf helper programs.

This should ease the burden of creating future autoconf-based backends.

To post a comment you must log in.
lp://staging/~mterry/pkgme/autoconf-helpers updated
51. By Michael Terry

whoops, remove some debugging code

Revision history for this message
James Westby (james-w) wrote :

Hi,

That's a nice simple change, thanks.

I wonder if we want a set of helpers, or we want these to be part of an autoconf
backend?

We could make it possible for the vala backend to query the autoconf backend for
these values.

Thanks,

James

review: Needs Information
Revision history for this message
Michael Terry (mterry) wrote :

I'm not sure if an autoconf backend would be useful on its own? Plus, helper scripts have the possibility of doing more than just the set of backend functions (e.g. the pkgme_autoconf_initfield helper script).

I could maybe imagine a need for non-build-system-related helper scripts in future...? In which case, where to put them?

If you were thinking it might eventually be useful for inheritance, I would disagree, as a backend like vala may eventually want to support other build systems (e.g. cmake) too and that would be difficult with inheritance.

Revision history for this message
James Westby (james-w) wrote :

Hi,

Sorry for the delay. You make good points, so I refactored some of the code
to reduce some duplication (that was already there), and merged.

Thanks,

James

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches