Code review comment for lp://staging/~mterry/indicator-sound/greeter-volume

Revision history for this message
Ted Gould (ted) wrote :

I think we should change a few things here.

* I think that a better way to detect if we're on the greeter or not is to check which user we're running as. Just checking to see if a name is owned could get messed up pretty easily. It also means we don't have a race with dbus getting the name owner ever. We know our username at start.

* I'd like to see the accounts service support use the accounts service lib. It seems like a better solution.

* I'd like to see the greeter interface as an object. Vala makes this pretty easy, and it's much better than calling the dbus connection directly.

For the last two I think the easiest way to do them might be to base your branch on:

https://code.launchpad.net/~ted/indicator-sound/greeter-control/+merge/209338

Which sets those up already.

review: Needs Fixing

« Back to merge proposal