Code review comment for lp://staging/~mterry/gsettings-ubuntu-touch-schemas/volume

Revision history for this message
Iain Lane (laney) wrote :

Yes, but we'd have to update the in-progress telephony-service landing and add the schemas to it to rename the keys. I can do that if we decide we want to.

As for this landing, I already expressed my distaste on IRC, but I'll put it here for the record and abstain since I want to defer to others.

I don't like using settings schemas to synchronise state between different parts of the system. In my opinion the session and the greeter ought to be able to communicate things like this between themselves and not go via an intermediary.

And could you please try to keep merge proposals about one change only? The CLEANFILES fix is probably small enough but you also changed SecurityPrivacy here.

review: Abstain

« Back to merge proposal