Code review comment for lp://staging/~mterry/deja-dup/tempdir-archive-dir

Revision history for this message
Robert Bruce Park (robru) wrote :

So, the diff looks quite nice, but 'make check' failed with this error:

/scripts/instance-error: OK
/scripts/mkdir: OK
/scripts/nag:
** (/home/robru/Applications/deja-dup/tempdir-archive-dir/tests/.libs/lt-runner:4911): WARNING **: runner.vala:292: Error string didn't match; expected (null), got Failed with an unknown error.
/bin/bash: line 1: 4911 Trace/breakpoint trap (core dumped) top_builddir=.. srcdir=. dbus-launch ./runner $test
make[1]: *** [check] Error 133
make[1]: Leaving directory `/home/robru/Applications/deja-dup/tempdir-archive-dir/tests'
make: *** [check-recursive] Error 1

review: Needs Fixing

« Back to merge proposal