Merge lp://staging/~mpontillo/maas/iprange-notifications--bug-1393936 into lp://staging/~maas-committers/maas/trunk
Proposed by
Mike Pontillo
Status: | Merged |
---|---|
Approved by: | Mike Pontillo |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5986 |
Proposed branch: | lp://staging/~mpontillo/maas/iprange-notifications--bug-1393936 |
Merge into: | lp://staging/~maas-committers/maas/trunk |
Diff against target: |
570 lines (+394/-16) 7 files modified
src/maasserver/forms/settings.py (+22/-13) src/maasserver/models/config.py (+3/-1) src/maasserver/models/signals/__init__.py (+2/-0) src/maasserver/models/signals/iprange.py (+42/-0) src/maasserver/models/signals/staticipaddress.py (+21/-0) src/maasserver/models/subnet.py (+48/-0) src/maasserver/models/tests/test_subnet.py (+256/-2) |
To merge this branch: | bzr merge lp://staging/~mpontillo/maas/iprange-notifications--bug-1393936 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Blake Rouse (community) | Approve | ||
MAAS Maintainers | Pending | ||
Review via email: mp+322569@code.staging.launchpad.net |
This proposal supersedes a proposal from 2017-04-07.
Commit message
Add notification for imminent IP address exhaustion on a subnet.
To post a comment you must log in.
Looks good overall. The way you've done the notifications appears sound. Updating the message on a notification instead of creating a new notification will have the effect of updating the message in the UI, but will not cause the notification to pop up again for people who have already dismissed it.