MAAS

Merge lp://staging/~mpontillo/maas/beaconing-packet-format into lp://staging/~maas-committers/maas/trunk

  1. beaconing-packet-format
  2. Merge into trunk
Proposed by Mike Pontillo
Status: Merged
Approved by: Mike Pontillo
Approved revision: no longer in the source branch.
Merged at revision: 6099
Proposed branch: lp://staging/~mpontillo/maas/beaconing-packet-format
Merge into: lp://staging/~maas-committers/maas/trunk
Diff against target: 673 lines (+345/-74)
4 files modified
src/provisioningserver/security.py (+31/-9)
src/provisioningserver/tests/test_security.py (+55/-44)
src/provisioningserver/utils/beaconing.py (+135/-10)
src/provisioningserver/utils/tests/test_beaconing.py (+124/-11)
To merge this branch: bzr merge lp://staging/~mpontillo/maas/beaconing-packet-format
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
Review via email: mp+325601@code.staging.launchpad.net

Commit message

Add methods to encode and decode beacon packets.

Also, change the name of the Fernet methods to make it clear that the encryption is done using a pre-shared key (the MAAS shared secret).

Minor test suite refactoring for SharedSecretTestCase to make it more general.

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

I do have a few questions inline. Looks generally good, though.

review: Needs Information
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Thanks for the review. Some replies below. You've given me some things to think about, so I'll make this WIP for now.

Revision history for this message
Данило Шеган (danilo) wrote :

Looks great, thanks for the changes!

A few more things that you probably forgot to complete with it being past 1am :-)

Not blocking since the gist of the stuff is there (basically, you are not making use of the new exception and raw=True parameter).

review: Approve
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Thanks much for the review; some replies below.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.