Merge lp://staging/~mordred/python-fixtures/agressive-loggers into lp://staging/~python-fixtures/python-fixtures/trunk
Proposed by
Monty Taylor
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~mordred/python-fixtures/agressive-loggers |
Merge into: | lp://staging/~python-fixtures/python-fixtures/trunk |
Diff against target: |
48 lines (+18/-9) 1 file modified
lib/fixtures/_fixtures/logger.py (+18/-9) |
To merge this branch: | bzr merge lp://staging/~mordred/python-fixtures/agressive-loggers |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
python-fixtures committers | Pending | ||
Review via email: mp+150237@code.staging.launchpad.net |
Description of the change
In the case where Logger is instantiated with no arguments, what we want is to grab ALL of the logging that's out there. To that end, iterate through the loggerDict and take over anything that's found there too.
The idea came from the nosetests logcapture plugin after noticing that nose was capturing things that the logger fixture was not.
To post a comment you must log in.
Unmerged revisions
- 69. By Monty Taylor
-
Added missing import.
- 68. By Monty Taylor
-
Expand logic for handling the "grab everything" case.
Could we please get a test that this saves/restores properly?
Also loggers are hierarchical, so we should be able to just replace
everything with a single logger.