loggerhead

Code review comment for lp://staging/~mnordhoff/loggerhead/statictuples

  1. statictuples
  2. Merge into trunk-rich
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matt Nordhoff wrote:
> Matt Nordhoff wrote:
>> I wonder how much of an impact interning the stringified revnos would
>> have? They're tiny, but they add up, and most of them are duplicates...
>
> Although interning them when they're unmarshalled will lead to one ugly
> list comprehension...

as_st(x).intern()

isn't all that bad.

st(as_st(x[0]).intern(), as_st(x[1]).intern(),
   as_st(x[2]).intern()).intern()

Isn't great, but it isn't terrible, either.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrnGp4ACgkQJdeBCYSNAAP3oQCeJy17L/u1+obC2rmJpPaiu0Yd
D5QAoJD8Z1Z+b2KeTGAdZjer8SUBLm4s
=WRny
-----END PGP SIGNATURE-----

Reply

« Back to merge proposal