QtMir

Merge lp://staging/~mir-team/qtmir/server-client-acceptance into lp://staging/qtmir

  1. server-client-acceptance
  2. Merge into trunk
Proposed by Robert Carr
Status: Work in progress
Proposed branch: lp://staging/~mir-team/qtmir/server-client-acceptance
Merge into: lp://staging/qtmir
Diff against target: 730 lines (+629/-14)
13 files modified
tests/common/common.pri (+11/-11)
tests/modules/ApplicationManager/ApplicationManager.pro (+1/-1)
tests/modules/TaskController/TaskController.pro (+1/-1)
tests/qpa/acceptance-tests/acceptance-tests.pro (+20/-0)
tests/qpa/acceptance-tests/acceptance_tests.cpp (+147/-0)
tests/qpa/acceptance-tests/mir_test_framework/deferred_in_process_server.h (+39/-0)
tests/qpa/acceptance-tests/mir_test_framework/in_process_server.h (+47/-0)
tests/qpa/acceptance-tests/mir_test_framework/server_runner.cpp (+103/-0)
tests/qpa/acceptance-tests/mir_test_framework/server_runner.h (+61/-0)
tests/qpa/acceptance-tests/stub_graphics_platform.cpp (+150/-0)
tests/qpa/acceptance-tests/stub_graphics_platform.h (+46/-0)
tests/qpa/qpa.pro (+2/-0)
tests/tests.pro (+1/-1)
To merge this branch: bzr merge lp://staging/~mir-team/qtmir/server-client-acceptance
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Gerry Boland (community) Needs Information
Review via email: mp+230018@code.staging.launchpad.net

Commit message

Add a small framework for creating tests which exercise the QPA MirServerConfiguration from an external client.

Description of the change

Add a small framework for creating tests which exercise the QPA MirServerConfiguration from an external client. Add 2 simple tests as proof of concept...more to come!

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Could we have Mir exporting the Mir test frameworks & stubs somehow, instead of copypasting them here? The worry is if qtmir's copy goes out of date.

review: Needs Information
Reply
Revision history for this message
Robert Carr (robertcarr) wrote :

The stub platform may dissapear (some talk of Mir exporting a stub platform, or otherwise once mesa software + simple DRM is set up no reason to stub it out could just do real software in rendering in the acceptance tests).

I'm not sure about the test framework...I doubt exporting another library is going to go over happy on the Mir team so I thought just copying the code here was best, mostly just dependent on STL and pretty simple...

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:229
http://jenkins.qa.ubuntu.com/job/qtmir-ci/3/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-amd64-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-armhf-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/3/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

I've just skimmed through it (so I might very well be wrong), but It all looks as a way to test mir itself and not the interaction between mir and qt, which is what qtmir is all about.

I think the directory structure should match (or at least resemble) what we see in /src. It's "platforms/mirserver" over there, not "qpa". Not saying that "platforms/mirserver" is a good one but I do think src and test should match, so that you can easily find where are the tests for some piece of code and vice-versa.

Reply

Unmerged revisions

229. By Robert Carr

Merge lp:qtmir

228. By Robert Carr

Add some tests

227. By Robert Carr

Work on mir acceptance

226. By Robert Carr

Stubbiest acceptance test

225. By Robert Carr

Begin mir test fixture

224. By Robert Carr

Add acceptance skeleton

223. By Robert Carr

Move common test directory to prepare for new test dir

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches