Mir

Code review comment for lp://staging/~mir-team/mir/introduce-pointer-event

Revision history for this message
Robert Carr (robertcarr) wrote :

>> speed -> change?

Hey! You're back. Happy new years...we have some fun to have on evdev-input-platform ;)

Hmm. I agree its kind of confusing.

I think speed may be correct because change makes it seem like you are talking about change in the axis state over time. Imagine you are scrolling up and receive a +7...then you reverse the direction of your scroll...at one point you will hit +0 which has to be interpreted as a current scroll speed of zero, not a change in the scroll axis state over time (because the change would be zero). Likewise if this entire reveral of speed (say from +7 to -3) happens in a single input frame, -3 is not your change (which would be 10) but rather just your new negative speed.

I have this sinking feeling that I am turning things over wrong in my head though so will continue to think some today.

« Back to merge proposal