Merge lp://staging/~mikemc/maas/packaging-fix-1346538 into lp://staging/~maas-maintainers/maas/packaging

Proposed by Mike McCracken
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 330
Merged at revision: 330
Proposed branch: lp://staging/~mikemc/maas/packaging-fix-1346538
Merge into: lp://staging/~maas-maintainers/maas/packaging
Diff against target: 31 lines (+9/-5)
2 files modified
debian/changelog (+7/-5)
debian/maas-dns.postrm (+2/-0)
To merge this branch: bzr merge lp://staging/~mikemc/maas/packaging-fix-1346538
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Andres Rodriguez (community) Needs Fixing
Review via email: mp+238926@code.staging.launchpad.net

Commit message

- Ensure that the maas-dns postrm script removes maas-related includes from named.conf.options (LP: 1346538)

Description of the change

- Ensure that the maas-dns postrm script removes maas-related includes from named.conf.options (LP: 1346538)

To reproduce:
1. install maas
2. purge maas
3. remove bind9
3. attempt to reinstall bind9:
you should see :
...
Setting up bind9 (1:9.9.5.dfsg-3) ...
 * Starting domain name service... bind9 [fail]
invoke-rc.d: initscript bind9, action "start" failed.
dpkg: error processing package bind9 (--configure):
 subprocess installed post-installation script returned error exit status 1
Errors were encountered while processing:
 bind9
E: Sub-process /usr/bin/dpkg returned an error code (1)

/var/log/syslog will look like this:

Oct 20 13:03:39 pliable named[22179]: starting BIND 9.9.5-3-Ubuntu -u bind
Oct 20 13:03:39 pliable named[22179]: built with '--prefix=/usr' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--sysconfdir=/etc/bind' '--localstatedir=/var' '--enable-threads' '--enable-largefile' '--with-libtool' '--enable-shared' '--enable-static' '--with-openssl=/usr' '--with-gssapi=/usr' '--with-gnu-ld' '--with-geoip=/usr' '--with-atf=no' '--enable-ipv6' '--enable-rrl' '--enable-filter-aaaa' 'CFLAGS=-fno-strict-aliasing -DDIG_SIGCHASE -O2'
Oct 20 13:03:39 pliable named[22179]: ----------------------------------------------------
Oct 20 13:03:39 pliable named[22179]: BIND 9 is maintained by Internet Systems Consortium,
Oct 20 13:03:39 pliable named[22179]: Inc. (ISC), a non-profit 501(c)(3) public-benefit
Oct 20 13:03:39 pliable named[22179]: corporation. Support and training for BIND 9 are
Oct 20 13:03:39 pliable named[22179]: available at https://www.isc.org/support
Oct 20 13:03:39 pliable named[22179]: ----------------------------------------------------
Oct 20 13:03:39 pliable named[22179]: adjusted limit on open files from 4096 to 1048576
Oct 20 13:03:39 pliable named[22179]: found 8 CPUs, using 8 worker threads
Oct 20 13:03:39 pliable named[22179]: using 8 UDP listeners per interface
Oct 20 13:03:39 pliable named[22179]: using up to 4096 sockets
Oct 20 13:03:39 pliable named[22179]: loading configuration from '/etc/bind/named.conf'
Oct 20 13:03:39 pliable named[22179]: /etc/bind/named.conf.options:2: open: /etc/bind/maas/named.conf.options.inside.maas: file not found
Oct 20 13:03:39 pliable named[22179]: loading configuration: file not found
Oct 20 13:03:39 pliable named[22179]: exiting (due to fatal error)

Note that /etc/bind/named.conf.options still contains maas-related includes:

options { directory "/var/cache/bind";
include "/etc/bind/maas/named.conf.options.inside.maas";
auth-nxdomain no;
listen-on-v6 { any; }; };

This branch removes those.

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

This lgtm! However, please address the following:

1. Add a changelog entry
2. Backport this to lp:~maas-maintainers/maas/packaging.utopic

Thanks

review: Needs Fixing
Revision history for this message
Mike McCracken (mikemc) wrote :

Updated. Hopefully the changelog is correct now.
Apologies for any LP email spam related to my typo in attaching the wrong bug, apparently there's no way to remove that attachment on LP even though as far as I can tell the metadata in the repo is fixed.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

You can just visit the branch page and remove it there, I've just done it for you.

review: Approve
Revision history for this message
Mike McCracken (mikemc) wrote :

> You can just visit the branch page and remove it there, I've just done it for
> you.

Ah, thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches