Merge lp://staging/~mihirsoni/ubuntu-calendar-app/bottomEdge into lp://staging/ubuntu-calendar-app

FAILED: Continuous integration, rev:547
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1028/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/175
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/175/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/25

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1028/rebuild

FAILED: Continuous integration, rev:548
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1029/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/222
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/222/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/26

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1029/rebuild

Why can't we add bottom edge to MainView( Calendar.qml), that way it will apply bottom edge to all views and also we dont need to create models as well.

Hi Kunal,

I did try to put this in MainView before , but it is not behaving properly while it comes to PageStack push.

With respect to your comment , I have changed logic and now I am just passing eventModel once, so we don't create models multiple time.

FAILED: Continuous integration, rev:549
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1030/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/240
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/240/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/27

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1030/rebuild

> Hi Kunal,
>
> I did try to put this in MainView before , but it is not behaving properly
> while it comes to PageStack push.
>
Can you create separate branch where I can try your code with bottom edge on MainView ?

Hi Kunal,

I have spoke to Rentu regarding as the Bottomege Page in Mainview as he said it might not be possible and he hasn't tried.

I have tried it in other branch , you can access that with

https://code.launchpad.net/~mihirsoni/+junk/MainViewBottomEdge

I have added code in MainView and only for Month view.

FAILED: Continuous integration, rev:549
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1034/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/358
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/358/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/31

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1034/rebuild

So the tests show failure because more than one new event page is found. Only one page is visible, but this still seems a bit weird to me. Note one is inside MonthView, while the other is on the page stack. Full log is here: http://paste.ubuntu.com/9221454/.

First NewEvent Object

== /comubuntucalendar/QQuickView/MainView/OrientationHelper/QQuickItem/QQuickItem/PageStack/PageWrapper/Tabs/QQuickItem/Tab/QQuickLoader/MonthView/QQuickRectangle/QQuickLoader/NewEvent ==
Children: [dbus.String('QQuickLoader_QML_2'), dbus.String('QQmlBind'), dbus.String('QQuickItem_QML_21'), dbus.String('QQmlComponentAttached'), dbus.String('QQuickLoader'), dbus.String('Object_QMLTYPE_3_QML_32'), dbus.String('PageHeadConfiguration_QMLTYPE_5'), dbus.String('Object_QMLTYPE_3_QML_78'), dbus.String('QDeclarativeOrganizerItemVisualReminder'), dbus.String('QDeclarativeOrganizerItemAudibleReminder'), dbus.String('QQuickPropertyAnimation'), dbus.String('QQmlComponent'), dbus.String('EventUtils_QMLTYPE_151'), dbus.String('QQuickFlickable_QML_158'), dbus.String('KeyboardRectangle_QMLTYPE_111'), dbus.String('QObject_QML_160'), dbus.String('QQuickKeysAttached'), dbus.String('QQmlContext'), dbus.String('QQuickLoader_QML_2'), dbus.String('QQuickItem_QML_21'), dbus.String('QQuickLoader'), dbus.String('QQuickFlickable_QML_158'), dbus.String('KeyboardRectangle_QMLTYPE_111')]
__isPageTreeNode: True
_autopilot_id: 13
active: False
activeFocus: False
activeFocusOnPress: True
activeFocusOnTab: False
antialiasing: False
baselineOffset: 0.0
clip: False
date: DateTime(2014-11-24 17:02:42)
enabled: True
endDate: DateTime(2014-11-24 18:02:42)
focus: False
globalRect: Rectangle(1275, 1400, 800, 568)
height: 568.0
id: 13
implicitHeight: 0.0
implicitWidth: 0.0
isEdit: False
isLeaf: True
objectName: 'newEventPage'
opacity: 1.0
rotation: 0.0
scale: 1.0
scrollY: -0.0
smooth: True
startDate: DateTime(2014-11-24 17:02:42)
state: ''
title: 'New Event'
transformOrigin: 4
visible: False
width: 800.0
x: 0.0
y: 0.0
z: 0.0

And the second NewEvent object

== /comubuntucalendar/QQuickView/MainView/OrientationHelper/QQuickItem/QQuickItem/PageStack/PageWrapper/NewEvent ==
Children: [dbus.String('QQuickLoader_QML_2'), dbus.String('QQmlBind'), dbus.String('QQuickItem_QML_21'), dbus.String('QQmlComponentAttached'), dbus.String('QQuickLoader'), dbus.String('Object_QMLTYPE_3_QML_32'), dbus.String('PageHeadConfiguration_QMLTYPE_5'), dbus.String('Object_QMLTYPE_3_QML_78'), dbus.String('QDeclarativeOrganizerItemVisualReminder'), dbus.String('QDeclarativeOrganizerItemAudibleReminder'), dbus.String('QQuickPropertyAnimation'), dbus.String('QQmlComponent'), dbus.String('EventUtils_QMLTYPE_151'), dbus.String('QQuickFlickable_QML_158'), dbus.String('KeyboardRectangle_QMLTYPE_111'), dbus.String('QObject_QML_160'), dbus.String('QQuickKeysAttached'), dbus.String('QQuickLoader_QML_2'), dbus.String('QQuickItem_QML_21'), dbus.String('QQuickLoader'), dbus.String('QQuickFlickable_QML_158'), dbus.String('KeyboardRectangle_QMLTYPE_111')]
__isPageTreeNode: True
_autopilot_id: 14
active: True
activeFocus: False
activeFocusOnPress: True
activeFocusOnTab: False
antialiasing: False
baselineOffset: 0.0
clip: False
date: DateTime(2014-11...

Hi Nic,

Thanks for updates. Yes we're yet to remove that page from pagestack as we have added NewEvent in bottomedge.
The concern is, as of now we don't have helpers for bottomedge.

Mihir, clock app recently fixed bottom edge support. For the moment, the toolkit doesn't have helpers (Leo mentioned it as not possible as there is no standard implementation). If that's the case, I think you can copy over the helper as written in clock. I believe file manager also recently had a bottom edge test implemented by Carla, so there's 2 examples.

I'd remove the extra page from the pagestack so you can work on the helpers for the bottom edge.

Andrea has implemented the new tests here: https://code.launchpad.net/~acerisara/ubuntu-calendar-app/bottom-edge-autopilot/+merge/244230

thanks for the work. Unfortunately a new component has landed on SDK. We are using that for now.