Code review comment for lp://staging/~michihenning/unity-scopes-api/qt-coverage

Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

Regarding: 1235 +// TODO: These are in the public API, so they need documentation.

I agree with Pawel. Maybe we should hide the full header from the public API and move it to the internal directory.

Those functions should not be used by any Qt user as they should only deal with QVariant.

Regarding the dates: most of the files were created in 2015, so not sure if we should use 2015 instead.

« Back to merge proposal