Code review comment for lp://staging/~michihenning/unity-scopes-api/lxc-registry

Revision history for this message
Michi Henning (michihenning) wrote :

I think the only place the lxc leaks out is in the LXC.ExecCommand key, which is not documented. But, yes, inappropriately named variables are no good regardless.

I agree that we shouldn't merge this mainly because we need a management decision to go ahead with the container approach. Otherwise, we might just end up with a bunch of useless code in the tree.

Once we have a decision, I can do the renaming as appropriate. For now, I don't want to sink any more time into it. I think the branch will survive for a few weeks. I'll re-merge devel every now and then to keep it alive until we know where we are headed.

« Back to merge proposal