Code review comment for lp://staging/~michihenning/unity-scopes-api/lxc-registry

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Still looking at this, but 2 small observations so far:

* Could you add a "Framework" key to our scope.ini description under the "Deployment" section of tutorial.dox.

* Perhaps it'd be worth throwing in one or two "meta.framework_major()" checks into Registry_test.cpp as well.

review: Needs Fixing

« Back to merge proposal