Code review comment for lp://staging/~michihenning/unity-scopes-api/add-logging

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

I noticed that there is one output you missed in ScopesWatcher.cpp, but I see you fixed it in unity-scopes-api/scopeswatcher, so we're good there. Other than that just QueryBase and ConfigBase seem to be left with standard output, but I can see how getting the logger into those classes is not simple.

So yeah, looks good to me! Nice work!

review: Approve

« Back to merge proposal