Code review comment for lp://staging/~michihenning/thumbnailer/vs-thumb-refactor

This looks pretty good. At first I thought there might be some issue with handling stdout/stderr, but the docs seem to indicate that QProcess will buffer all the output so that shouldn't be a problem.

It looks like any output to stderr from vs-thumb will be discarded on a successful thumbnail. This is probably okay, but might be a bit annoying if following the logs while trying to determine why vs-thumb is stuck somewhere.

I've left some extra inline comments, but they don't really find fault with any of the logic.