I landed the sprint-index update the other day, but subsequently a
view.label was added to a parent class of SprintView. It was my fault
for not have a test that explicitly ensured no h1 was included below the
app-tabs.
== Proposed fix ==
Specifically set the view.label to None for the SprintView. This is a
workaround for bug 435255.
= Summary =
This branch fixes bug 435269.
I landed the sprint-index update the other day, but subsequently a
view.label was added to a parent class of SprintView. It was my fault
for not have a test that explicitly ensured no h1 was included below the
app-tabs.
== Proposed fix ==
Specifically set the view.label to None for the SprintView. This is a
workaround for bug 435255.
== Pre-implementation notes ==
== Implementation details ==
== Tests ==
bin/test -vvt stories/sprints
== Demo and Q/A == people. canonical. com/~michaeln/ tmp/sprint- index-heading- before. png people. canonical. com/~michaeln/ tmp/sprint- index-should- hide-heading- after.png
Screenshots:
http://
http://
QA: https:/ /edge.launchpad .net/sprints/ uds-l
Demo: https:/ /launchpad. dev/sprints/ uds-guacamole
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: blueprints/ stories/ sprints/ 05-sprint- creation. txt blueprints/ browser/ sprint. py blueprints/ templates/ sprint- portlet- attendees. pt
lib/lp/
lib/lp/
lib/lp/
== Pyflakes notices ==
lib/lp/ blueprints/ browser/ sprint. py
35: 'Hierarchy' imported but unused
37: 'ApplicationMenu' imported but unused
== Pylint notices ==
lib/lp/ blueprints/ browser/ sprint. py
37: [W0611] Unused import ApplicationMenu
35: [W0611] Unused import Hierarchy
I removed this lint with r8503.
--
Michael