Code review comment for lp://staging/~michael.nelson/launchpad/missing-distro-ppas-heading

Revision history for this message
Michael Nelson (michael.nelson) wrote :

= Summary =

This branch fixes the distribution ppas view, which was updated to 3-0
before the requirement of view.label for the main heading.

You can see the missing heading at:

https://edge.launchpad.net/ubuntu/+ppas

I also updated the page_title to something shorter now that it's used as
the leaf of the breadcrumbs (and first part of the page-title).

== Tests ==

bin/test -vv -t distribution-views.txt -t xx-ubuntu-ppas.txt -t
stories/soyuz -t stories/ppa

== Demo and Q/A ==

Screenshot:
http://people.canonical.com/~michaeln/tmp/distro-ppa-heading.png

Demo:
https://launchpad.dev/ubuntu/+ppas

QA:
https://edge.launchpad.net/ubuntu/+ppas

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt
  lib/lp/soyuz/templates/distribution-ppa-list.pt
  lib/lp/registry/browser/tests/distribution-views.txt
  lib/lp/registry/browser/distribution.py

--
Michael

« Back to merge proposal