Merge lp://staging/~michael.nelson/launchpad/distro-series-difference-message into lp://staging/launchpad/db-devel
Proposed by
Michael Nelson
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Michael Nelson | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 9726 | ||||
Proposed branch: | lp://staging/~michael.nelson/launchpad/distro-series-difference-message | ||||
Merge into: | lp://staging/launchpad/db-devel | ||||
Prerequisite: | lp://staging/~michael.nelson/launchpad/distro-series-difference-basic-model | ||||
Diff against target: |
379 lines (+255/-4) 8 files modified
lib/lp/registry/configure.zcml (+12/-0) lib/lp/registry/interfaces/distroseriesdifference.py (+8/-1) lib/lp/registry/interfaces/distroseriesdifferencecomment.py (+57/-0) lib/lp/registry/model/distroseriesdifference.py (+22/-1) lib/lp/registry/model/distroseriesdifferencecomment.py (+67/-0) lib/lp/registry/tests/test_distroseriesdifference.py (+29/-2) lib/lp/registry/tests/test_distroseriesdifferencecomment.py (+44/-0) lib/lp/testing/factory.py (+16/-0) |
||||
To merge this branch: | bzr merge lp://staging/~michael.nelson/launchpad/distro-series-difference-message | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Launchpad code reviewers | Pending | ||
Review via email: mp+33929@code.staging.launchpad.net |
Commit message
Add DistroSeriesDif
Description of the change
Overview
========
Hi Brad or other reviewer :)
This branch adds the comment model for DistroSeriesDif
This is part of the work for:
https:/
To test:
bin/test -vv -m lp.registry.
No lint.
To post a comment you must log in.
Hi Michael,
Thanks for this addition.
I think this would read better if the actual were on a line by itself.
279 + self.assertEqual(
280 + "Difference between distroseries 'Lucid' and 'Derilucid' "
281 + "for package 'foonew' (1.0/0.9)", ds_diff.title)
Otherwise it looks great.