It's very picky, but I think I'd find the tests easier to understand if you gave the times names, like so:
earliest = now - timedelta(seconds=20) latest = now - timedelta(seconds=10) in_between = now - timedelta(seconds=15)
and use keyword arguments in the calls to recordSuccess then it's a bit easier to see the relationship between them. Not 100% sure about the names.
Even if you don't do this, the change looks good to land. Congratulations on finding the problem :-)
« Back to merge proposal
It's very picky, but I think I'd find the tests easier to understand if you gave the times names, like so:
earliest = now - timedelta( seconds= 20) seconds= 10) seconds= 15)
latest = now - timedelta(
in_between = now - timedelta(
and use keyword arguments in the calls to recordSuccess then it's a bit easier to see the relationship between them. Not 100% sure about the names.
Even if you don't do this, the change looks good to land. Congratulations on finding the problem :-)