Code review comment for lp://staging/~michael.nelson/launchpad/567922-binarypackagebuild-new-table-1

Revision history for this message
Aaron Bentley (abentley) wrote :

distro_series should be defined on IPackageBuild, because it's common to all packages, even though the implementation will differ for ISourcePackageRecipeBuild and IBinaryBuild. If needed, define a property on IPackageBuild that raises NotImplementedError.

diff lines 342-343 need to be re-indented.

I'm also concerned about the split between IPackageBuild and IPackageBuildDerived. It seems like there should only be one interface for things that are "package builds", so please see if you can unify them, or at least make it clear that IPackageBuild only exists to represent the PackageBuild model object.

« Back to merge proposal