Code review comment for lp://staging/~michael.nelson/launchpad/418024-ppa-packages-traversal

Revision history for this message
Michael Nelson (michael.nelson) wrote :

= Summary =

This is the first branch of a pipeline of changes for the new PPA-index
page described at:

https://dev.launchpad.net/VersionThreeDotO/Soyuz/PPAUI

This branch specifically creates a new traversal from a PPA, /+packages
and replicates all the detailed package info/interactions from the
current ppa/index to /+packages.

A subsequent branch in the pipeline then updates the PPA index page.

== Proposed fix ==

== Pre-implementation notes ==

== Implementation details ==

There are two XXX's in this branch.

bug 420376 is related to the copy/delete packages links displayed on the
/+packages traversal. I've not used a main_side layout as (1) there is
no other information for the side-bar, and (2) these links will
disappear when the copy/delete functionality is presented on this page.

bug 419921 - in the build status summary, we want to link to a filtered
view of each summary (Pending, Successful, Failed), but currently cannot
as the filtering options do not yet match.

== Tests ==
bin/test -vv -t archive-views.txt -t xx-ppa-packages.txt

== Demo and Q/A ==

Visit:

https://launchpad.dev/~cprov/+archive/ppa/+packages

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/icing/style.css
  lib/lp/soyuz/browser/tests/archive-views.txt
  lib/lp/soyuz/interfaces/archive.py
  lib/lp/soyuz/templates/archive-macros.pt
  lib/lp/soyuz/templates/archive-packages.pt
  lib/lp/soyuz/browser/configure.zcml
  lib/lp/soyuz/stories/ppa/xx-ppa-packages.txt
  lib/lp/soyuz/model/archive.py
  lib/lp/soyuz/browser/archive.py

== Pylint notices ==

lib/lp/soyuz/interfaces/archive.py
    41: [F0401] Unable to import 'lazr.enum' (No module named enum)
    54: [F0401] Unable to import 'lazr.restful.declarations' (No module
named restful)
    60: [F0401] Unable to import 'lazr.restful.fields' (No module named
restful)

lib/lp/soyuz/model/archive.py
    14: [F0401] Unable to import 'lazr.lifecycle.event' (No module named
lifecycle)

--
Michael

« Back to merge proposal