Merge lp://staging/~mhall119/ubuntu-website/fixes-596364 into lp://staging/~ubuntu-website-community/ubuntu-website/light-base-theme
Proposed by
Michael Hall
| Status: | Needs review | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~mhall119/ubuntu-website/fixes-596364 | ||||
| Merge into: | lp://staging/~ubuntu-website-community/ubuntu-website/light-base-theme | ||||
| Diff against target: |
26 lines (+3/-2) 2 files modified
css/default.css (+1/-1) index.html (+2/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~mhall119/ubuntu-website/fixes-596364 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Lustfield (community) | extra-touchup | Approve | |
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Michael Lustfield (michaellustfield) wrote | # |
review:
Approve
(extra-touchup)
Unmerged revisions
- 3. By Michael Hall <mhall@mhall-laptop>
-
Wrap top-loco and loco text in a link to the site root
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I noticed this on line 22:
src="http://
There is an extra / "com//sites".
I'm curious. Should we link to an image on another server. This will involve an additional DNS resolution to pull it down. For the sake of the base theme I can see this remaining but I can't see it being a good idea to replicate through the other branches.
Aside from that, I think the diff looks great.