Code review comment for lp://staging/~mhall119/ubuntu-website/fixes-596364

Revision history for this message
Michael Lustfield (michaellustfield) wrote :

I noticed this on line 22:
src="http://www.ubuntu.com//sites/default/themes/ubuntu10/logo.png"

There is an extra / "com//sites".
I'm curious. Should we link to an image on another server. This will involve an additional DNS resolution to pull it down. For the sake of the base theme I can see this remaining but I can't see it being a good idea to replicate through the other branches.

Aside from that, I think the diff looks great.

review: Approve (extra-touchup)

« Back to merge proposal