Code review comment for lp://staging/~mhall119/ubuntu-accomplishments-web/add-json-service
Revision history for this message
| Gabriel Patiño (gepatino) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9199653
demo site
(Get the code!)
Very nice, I have some comments/questions:
* if an entity is not found (wrong id in the url) wouldn't it be better to return a 404 status code?
* the same for the unsupported operations (the api could return a 501 Not Implemented, 400 Bad Request, 403 Forbidden, or something like that)
* I would remove the code not relevant to the web gallery (room, agenda, participant, crew, etc)
my two cents