Code review comment for lp://staging/~mdione/lalita/url-plugin

Revision history for this message
Facundo Batista (facundo) wrote :

Some details:

- When logging, use the safe way to build strings... like this (not using '%'):

    logger.debug('command_char: %s', self.command_char)

- Don't log 'msg' *again* in the cases of "found he's talking to me" and "command char found" (no point of having a bigger log and more difficult to read if the info is already there)

- Revert the change in seen.py (the separation for the class should be two lines, and there's no point of touching a file in the history only for a blank change).

- Try to be pep 8, please!

review: Needs Fixing

« Back to merge proposal