Merge lp://staging/~mc-return/compiz/compiz.merge-fix1033877-fix-uninitialized-class-member-variables-in-constructors-part2 into lp://staging/compiz/0.9.9

Proposed by MC Return
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 3453
Merged at revision: 3449
Proposed branch: lp://staging/~mc-return/compiz/compiz.merge-fix1033877-fix-uninitialized-class-member-variables-in-constructors-part2
Merge into: lp://staging/compiz/0.9.9
Diff against target: 106 lines (+28/-6)
6 files modified
plugins/firepaint/src/firepaint.cpp (+6/-2)
plugins/grid/src/grid.h (+6/-1)
plugins/opengl/src/screen.cpp (+1/-0)
plugins/showmouse/src/showmouse.cpp (+6/-2)
plugins/trip/src/trip.cpp (+7/-0)
src/stackdebugger.cpp (+2/-1)
To merge this branch: bzr merge lp://staging/~mc-return/compiz/compiz.merge-fix1033877-fix-uninitialized-class-member-variables-in-constructors-part2
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+132830@code.staging.launchpad.net

Commit message

Initialized all class member variables in their respective constructors.
Used false for bools, 0 for ints. (LP: #1033877)

To post a comment you must log in.
3453. By MC Return

Also initialize the member variable bool mTimeoutRequired in the Stackdebugger::Stackdebugger (...) constructor

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches