Code review comment for lp://staging/~mbruzek/charms/trusty/apache2/nagios_extra_check_https

Revision history for this message
Samuele Pedroni (pedronis) wrote :

> Ouch on that formatting.. how about this: http://paste.ubuntu.com/13001287/

sorry been busy with other things, I'm not against if the ecosys team thinks is not too strange,

about that code, in the case of a simple string this works because the for check_http will be one char strings and so we get the TypeError, defensively I would put the try except just around

name = check_http['name']

or even be more explicit separating cases

« Back to merge proposal