Launchpad itself

Merge lp://staging/~mbp/launchpad/323000-affecting-user into lp://staging/launchpad

323000-affecting-user
Merge into devel

Proposed by Martin Pool on 2011-09-29

Status:

Merged

Approved by:

Martin Pool on 2011-09-29

Approved revision:

no longer in the source branch.

Merged at revision:

14078

Proposed branch:

lp://staging/~mbp/launchpad/323000-affecting-user

Merge into:

lp://staging/launchpad

Diff against target:

246 lines (+109/-23)

4 files modified

lib/lp/bugs/browser/configure.zcml (+7/-0)
lib/lp/registry/browser/person.py (+71/-12)
lib/lp/registry/browser/tests/test_person_view.py (+19/-1)
lib/lp/registry/stories/person/xx-person-bugs.txt (+12/-10)

To merge this branch:

bzr merge lp://staging/~mbp/launchpad/323000-affecting-user

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Gavin Panella (community)	code	2011-09-29	Approve on 2011-09-29
Raphaël Badin (community)	code*	2011-09-29	Approve on 2011-09-29
Review via email: mp+77469@code.staging.launchpad.net

Commit message

[r=allenap,rvb][bug=323000] add and link to https://bugs.launchpad.net/~/+affectingbugs

Description of the change

Fix bug 323000 by adding https://bugs.launchpad.net/~/+affectingbugs

Also change the phrasing on that page from "List foo" into just "Foo" in line with general good style for web links.

Revision history for this message

Martin Pool (mbp) wrote on 2011-09-29:

The implementation of per-user bug listings seems inconsistent with how it is done within pillars, and there is a fair amount of copy-and-paste within the different filters. But both of those are way out of scope for this bug.

screenshot https://bugs.launchpad.net/launchpad/+bug/323000/+attachment/2478784/+files/20110929_002.png

Revision history for this message

Raphaël Badin (rvb) wrote on 2011-09-29:

Hi Martin, simple change but a really useful one I reckon. And thank you for removing the "List" in front of all the links, this was really only visual noise.

This looks good to land but I've a few nitpicks:

[1]

The code duplication is indeed a little bit frightening within that file. Maybe it's worth adding an XXX along with a tech-debt bug?

[2]

88 +class PersonAffectingBugTaskSearchListingView(RelevantMilestonesMixin,
89 + BugTaskSearchListingView):

This is really a detail but could you please fix the indentation?

[3]

155 +class TestPersonAffectingBugTaskSearchListingView(
156 + BugTaskViewsTestBase, TestCaseWithFactory):
157 + """Tests for PersonAffectingBugTaskSearchListingView."""
158 +
159 + view_name = '+affectingbugs'
160 +
161 + def setUp(self):
162 + super(TestPersonAffectingBugTaskSearchListingView, self).setUp()
163 + # Bugs filed by this user are marked as affecting them by default, so
164 + # the bug we filed is returned.
165 + self.expected_for_search_unbatched = [
166 + self.owned_bug.default_bugtask,
167 + ]

I understand that owned bugs are also affecting bugs but maybe it would be worth populating a variable named self.affecting_bug and to create a test to make sure that affecting bugs (not owned bugs) are displayed.

review: Approve (code*)

Revision history for this message

Gavin Panella (allenap) wrote on 2011-09-29:

Awesome, this will make a lot of people happy :) I have nothing to add to Raphaël's review.

review: Approve (code)

Revision history for this message

Martin Pool (mbp) wrote on 2011-09-29:

[1] I think the code duplication is obvious enough without a comment to point it out ;-) and I think Robert's current favoured approach is not to do tech-debt bugs, on the theory that people will remove it when it annoys them, so the bug is just noise.

[2] done

[3] good idea; done

Revision history for this message

Martin Pool (mbp) wrote on 2011-09-29:

... just to expand a bit on the point of code duplication: i think the major problem here is not duplication between classes in the same file, but duplication between person bug views and other bug views. We could almost make bugs.l.n/~mbp point you to https://bugs.launchpad.net/bugs/+bugs?field.reporter=mbp which gives similar information without using the one-off views, but then it's hard to do further navigation either to bugs with different relationships to me, or to narrow that view. But that's a general problem (for which I'm sure there's another bug) of refinement of bug searches being hard.