Merge lp://staging/~mbp/bzr/error-reporting into lp://staging/bzr
Proposed by
Martin Pool
Status: | Superseded |
---|---|
Proposed branch: | lp://staging/~mbp/bzr/error-reporting |
Merge into: | lp://staging/bzr |
Prerequisite: | lp://staging/~mbp/bzr/assert-doctest |
Diff against target: |
183 lines (+90/-13) (has conflicts) 5 files modified
bzrlib/crash.py (+21/-9) bzrlib/plugin.py (+11/-0) bzrlib/tests/__init__.py (+1/-1) bzrlib/tests/test_crash.py (+47/-3) doc/en/release-notes/bzr-2.3.txt (+10/-0) Text conflict in bzrlib/crash.py Text conflict in bzrlib/tests/test_crash.py Text conflict in doc/en/release-notes/bzr-2.3.txt |
To merge this branch: | bzr merge lp://staging/~mbp/bzr/error-reporting |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Approve | ||
Review via email:
|
This proposal supersedes a proposal from 2011-03-31.
This proposal has been superseded by a proposal from 2011-03-31.
Description of the change
Per bug 716389 and previous feedback, this now shows just a concisely list of plugins in the non-apport crash message
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/28/2011 03:16 AM, Martin Pool wrote: /bugs.launchpad .net/bzr/ +bug/716389 /code.launchpad .net/~mbp/ bzr/error- reporting/ +merge/ 55029
> Martin Pool has proposed merging lp:~mbp/bzr/error-reporting into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> Bug #716389 in Bazaar: "In-terminal crash report is far too long, containing full `bzr plugins` output"
> https:/
>
> For more details, see:
> https:/
>
> This stops bzr printing a full list of plugins (too long!) on a non-apport error; per bug 716389
>
What if we printed out the short forms, rather than the long form. Right jameinel/ dev/bzr/ bzr.dev/ bzrlib/ plugins/ news_merge
now we show:
news_merge 2.4.0dev2
Merge hook for bzr's NEWS file.
/home/
qbzr 0.20.0 lib/python2. 6/dist- packages/ bzrlib/ plugins/ qbzr
QBzr - Qt-based frontend for Bazaar
/usr/
weave_fmt jameinel/ dev/bzr/ bzr.dev/ bzrlib/ plugins/ weave_fmt
Weave formats.
/home/
And I agree that it is overly verbose. We could, instead do: l_store 2.4.0dev2
bash_completion 2.4.0dev2
bzrtools 2.3.1
changelog_merge 2.4.0dev2
launchpad 2.4.0dev2
loggerhead 1.18.0
netrc_credentia
news_merge 2.4.0dev2
qbzr 0.20.0
weave_fmt
I actually do find it useful to see the plugin versions as part of bug
reports that people manually copy & paste. I don't think we want to get
rid of it completely. I wonder if we could even put them all-on-one-line
like:
bash_completion 2.4.0dev2, bzrtools 2.3.1, changelog_merge 2.4.0dev2, l_store
launchpad 2.4.0dev2, loggerhead 1.18.0, netrc_credentia
2.4.0dev2, news_merge 2.4.0dev2, qbzr 0.20.0, weave_fmt
That would still allow us to say "the bug is in bzr-svn, and you're
running an older version".
Just a thought. I don't think I want to completely get rid of the plugin
list. I do agree that it obscures seeing the backtrace the way it is now.
John enigmail. mozdev. org/
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk2 QcWYACgkQJdeBCY SNAAOr5ACfV4PuA XPTIomnKxTE6Jc3 MAd8 X0160a5EQg1eXgj xE
oMgAoMWBSWUkh7f
=4fJS
-----END PGP SIGNATURE-----