Code review comment for lp://staging/~mbp/bzr/error-reporting

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/28/2011 03:16 AM, Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/error-reporting into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> Bug #716389 in Bazaar: "In-terminal crash report is far too long, containing full `bzr plugins` output"
> https://bugs.launchpad.net/bzr/+bug/716389
>
> For more details, see:
> https://code.launchpad.net/~mbp/bzr/error-reporting/+merge/55029
>
> This stops bzr printing a full list of plugins (too long!) on a non-apport error; per bug 716389
>

What if we printed out the short forms, rather than the long form. Right
now we show:
news_merge 2.4.0dev2
  Merge hook for bzr's NEWS file.
   /home/jameinel/dev/bzr/bzr.dev/bzrlib/plugins/news_merge

qbzr 0.20.0
  QBzr - Qt-based frontend for Bazaar
   /usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr

weave_fmt
  Weave formats.
   /home/jameinel/dev/bzr/bzr.dev/bzrlib/plugins/weave_fmt

And I agree that it is overly verbose. We could, instead do:
bash_completion 2.4.0dev2
bzrtools 2.3.1
changelog_merge 2.4.0dev2
launchpad 2.4.0dev2
loggerhead 1.18.0
netrc_credential_store 2.4.0dev2
news_merge 2.4.0dev2
qbzr 0.20.0
weave_fmt

I actually do find it useful to see the plugin versions as part of bug
reports that people manually copy & paste. I don't think we want to get
rid of it completely. I wonder if we could even put them all-on-one-line
like:

bash_completion 2.4.0dev2, bzrtools 2.3.1, changelog_merge 2.4.0dev2,
launchpad 2.4.0dev2, loggerhead 1.18.0, netrc_credential_store
2.4.0dev2, news_merge 2.4.0dev2, qbzr 0.20.0, weave_fmt

That would still allow us to say "the bug is in bzr-svn, and you're
running an older version".

Just a thought. I don't think I want to completely get rid of the plugin
list. I do agree that it obscures seeing the backtrace the way it is now.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2QcWYACgkQJdeBCYSNAAOr5ACfV4PuAXPTIomnKxTE6Jc3MAd8
oMgAoMWBSWUkh7fX0160a5EQg1eXgjxE
=4fJS
-----END PGP SIGNATURE-----