Code review comment for lp://staging/~mbp/bzr/deprecation-old

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/deprecation-old into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> Just removing a bit more deprecated cruft.
>

I'm happy to bring in the deprecation and cleanup, though
+ @deprecated_method(deprecated_in((1, 17, 0)))
     def note(self, fmt_string, *args):

^- I'm not sure that we want to backport our deprecations. :)

So other than that line

 review: approve
 merge: approve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkq6KpMACgkQJdeBCYSNAAOaEgCfXar7AaA565CrgLybXu+O8GPz
rksAn3RU76sYdo+4gCji7WPpwALgYHng
=MzqU
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal