Code review comment for lp://staging/~mbp/bzr/409684-cherrypick

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/409684-cherrypick into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>

So you could do this with:
  target = self.make_branch_and_tree('target')
  target.set_root_id(source.get_root_id())

That might be better than actually branching. But since this is testing
cherrypicking and we are branching before 'rev1' is committed, I don't
think this violates what the test is trying to accomplish.

  review approve
  merge approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkp606UACgkQJdeBCYSNAAN+FACeNVbZBHa9+6+JOhyLfP1pnzj/
XvgAoI6s5lN3av2bT91mHJuSJUIsvhUj
=0kCZ
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal