Code review comment for lp://staging/~maxb/bzr-builddeb/better-error-multiple-upstream-tarballs

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Thanks :)

That last bit seems shorter as:

self.addCleanup(extractor.cleanup)
self.assertRaises(MultipleUpstreamTarballsNotSupported, extractor.extract)

rather than:

+ try:
124 + try:
125 + extractor.extract()
126 + self.fail("Expected exception not thrown")
127 + except MultipleUpstreamTarballsNotSupported:
128 + pass # Expected
129 + finally:
130 + extractor.cleanup()

review: Approve

« Back to merge proposal