Code review comment for lp://staging/~mardy/ubuntuone-credentials/signon-plugin-part1

Revision history for this message
Alberto Mardegan (mardy) wrote :

To clarify: I'm talking about silo 79 (https://requests.ci-train.ubuntu.com/#/ticket/1049). No matter what the train says, the packages in the silo PPA appear to be working as expected, and testing is quite easy: create an U1 plugin, then go to the website to revoke the token and finally try to install an app from the click scope.
You will get a dialog like this beauty: http://www.mardy.it/archivos/ubuntuone.png
If you enter the correct credentials, the package installation will start; otherwise, the dialog will reappear. And indeed, if you type the right credentials but you have 2fa enabled, the dialog will reappear and will have an additional field for the 2fa.

Before you say it: I'm aware of the uglyness of the dialog, and also that it would be a much better experience if the dialog didn't close at every attempt, but instead remain on screen with a spinner until the authentication has completed.
Both these things are solvable; the first with some UI designers input, the latter with some non trivial changes to ussoa, which I didn't start doing given that U1 was the only account requiring these changes, and I was not sure whether the U1 authentication plugin was ever going to land.
However, now that it appears that we are going to have an owncloud plugin, I might get started on them anyway.

« Back to merge proposal